Maravel-Framework 10.61.0
There were multiple attempts to add this feature in Laravel like:
- https://github.com/laravel/framework/pull/7642
- https://github.com/laravel/framework/pull/36542
- https://github.com/laravel/framework/pull/47271
Because the macroable classes are resolved from the container in Maravel-Framework, there are some corner cases like IlluminateEventsDispatcher or IlluminateConsoleSchedulingSchedule which if resolved from container would generate circular dependency that leads to segmentation fault or memory exhaustion.
This can happen also to developers leading to long debug time.
To shorten the detection of such cases , this PR introduces a hard limit of 10 MB by default, configurable via app.circular_dependency_memory_limit:
/**
* Limit of extra memory used to detect circular dependencies when resolving an abstract from container (bytes)
*/
'circular_dependency_memory_limit' => 10485760,
The error it generates:
IlluminateContractsContainerCircularDependencyException
Circular dependency detected while resolving [IlluminateConsoleSchedulingSchedule]. Memory limit reached or exceeded 10485760 bytes. Dependencies initial memory (bytes):{“IlluminateConsoleSchedulingSchedule”:27262976}
at vendor/macropay-solutions/maravel-framework/illuminate/Container/Container.php:886
This translates to:
When IlluminateConsoleSchedulingSchedule starts to be resolved from container, the memory used by PHP, read via*memory_get_usage(true),* was 27262976 bytes. Then the code went in an infinite loop until the memory difference exceeded 10 MB ( 10485760 bytes ), meaning the memory used by PHP was greater or equal to 27262976 + 10485760 bytes. If not stopped, this would continue until a segmentation fault would trigger a hard to debug memory exhausted fatal error.
Notes:
The limit based on time gives segmentation fault/memory limit fatal.
My first try to limit based on increments is not reliable as it can be seen here.
This is a second improvement after the di helper that does not call make on the container if it did not finish booting.